On Sun, Mar 13, 2016 at 03:10:13AM -0400, Vivien Didelot wrote: > Andrew Lunn <and...@lunn.ch> writes: > > > All the drivers support multiple chips, but mv88e6123_61_65 is the > > only one that reflects this in its naming. Change it to be consistent > > with the other drivers. > > > > Signed-off-by: Andrew Lunn <and...@lunn.ch> > > Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> > > When mv88e6xxx will become a driver by its own supporting different > devices, it'll be good to rename it to a reference driver as well, say > mv88e6352.
In device tree land, the convention is to use the lowest version number supported. So it will probably be called mv88e6085.c. > > > diff --git a/drivers/net/dsa/mv88e6123.c b/drivers/net/dsa/mv88e6123.c > > new file mode 100644 > > index 000000000000..69a6f79dcb10 > > --- /dev/null > > +++ b/drivers/net/dsa/mv88e6123.c > > @@ -0,0 +1,124 @@ > > Note that to avoid the big diff above, you can use the -M option of > git-format-patch to detect file renames. Yes, i always forget that. I wounder why it is not turned on by default? Maybe older versions of patch do not understand it? Andrew