Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> : [...] > >@@ -7083,8 +7084,11 @@ rtl_init_one(struct pci_dev *pdev, const struct > >pci_device_id *ent) > > } > > tp->mmio_addr = ioaddr; > > > >- if (!pci_is_pcie(pdev)) > >+ if (!pci_is_pcie(pdev)) { > > netif_info(tp, probe, dev, "not PCI Express\n"); > >+ tp->pcie = 0; > >+ } else > >+ tp->pcie = 1; > > Same question, you should assign true/false.
He should not bloat the private struct in the first place and the log message adds no value but the change makes sense. -- Ueimor