From: Aaron Young <aaron.yo...@oracle.com>
Date: Tue,  8 Mar 2016 07:02:34 -0800

> @@ -719,12 +720,13 @@ static void maybe_tx_wakeup(struct vnet_port *port)
>       __netif_tx_unlock(txq);
>  }
>  
> -static inline bool port_is_up(struct vnet_port *vnet)
> +inline bool port_is_up_common(struct vnet_port *vnet)

All of these things in foo.c files shouldn't have an inline attribute.

>  {
>       struct vio_driver_state *vio = &vnet->vio;
>  
>       return !!(vio->hs_state & VIO_HS_COMPLETE);
>  }
> +EXPORT_SYMBOL(port_is_up_common);

Especially if they are also exported.

Need to use EXPORT_SYMBOL_GPL() here as well, but I seriously think you need to 
rename
this function in order to not pollute the global namespace of exported kernel 
symbols.
You need to add a suitable prefix such as sunvnet_*() or whatever.

Reply via email to