On Sun, Mar 6, 2016 at 3:43 AM, Nikolay Aleksandrov
<niko...@cumulusnetworks.com> wrote:
> On 03/05/2016 03:44 PM, Xin Long wrote:
>
> See the comment above dev_ifsioc:
> /*
> * Perform the SIOCxIFxxx calls, inside rtnl_lock()
> */
> static int dev_ifsioc(struct net *net, struct ifreq *ifr, unsigned int cmd)
> {
> ...
> it is usually called like:
> rtnl_lock();
> ret = dev_ifsioc(net, &ifr, cmd);
> rtnl_unlock();
> And also you cannot be calling netdevice notifiers without RTNL. So in any
> case you do need it here as well, in fact you'll surely hit the ASSERT_RTNL();
> in call_netdevice_notifiers_info if you do so, thus I'm not sure how this
> patch was actually tested.
>
yes, I can see it now.
I will repost this patch with rtnl_lock in br_sysfs_*.
Thanks Nik.
>
