On Sat, Mar 05, 2016 at 11:33:12AM -0500, David Miller wrote:
> > and until everything get cleaned up I couldn't connect
> > to the node via ssh. I continue playing with patch maybe
> > I find some other optimization paths. Thanks!
>
> What is the order of magnitude of the delay, as a function of
> number of IP aliases installed, compred to before the patch?
You know I didn't measured precise numbers. The script (which
I of course forgot to attach in first report) creates 65025
addresses and on exit it takes ~10 minutes (it also depends
on load on the host because I've been testing inside VM).
I'll create some kind of graph for that if you interested,
should I?
> The remaining cost you are seeing comes of course from the router
> deletion, whose path is:
>
> blocking_notifier_call_chain(&inetaddr_chain, NETDEV_DOWN, ifa1);
> fib_inetaddr_event()
> fib_del_ifaddr(ifa, NULL);
>
> Which does another full list scan trying to handle primaries and
> secondaries.
>
> Probably the same optimization can be applied there, see patch below.
> And if that doesn't do it, there is a really easy way to batch the
> delete by scanning the FIB tree in one go and deleting every entry
> that points to "in_dev". But I suspect we really won't need that.
I'll test it David, in a couple of hours I hope. And report the
result.
Cyrill
