From: Herbert Xu <[EMAIL PROTECTED]> Date: Sun, 26 Mar 2006 22:39:02 +1100
> The error handling in ipcomp6_tunnel_create is broken in two ways: > > 1) If we fail to allocate an SPI (this should never happen in practice > since there are plenty of 32-bit SPI values for us to use), we will > still go ahead and create the SA. > > 2) When xfrm_init_state fails, we first of all may trigger the BUG_TRAP > in __xfrm_state_destroy because we didn't set the state to DEAD. More > importantly we end up returning the freed state as if we succeeded! > > This patch fixes them both. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Applied, thanks Herbert :) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
