On Thu, Mar 23, 2006 at 02:37:35PM -0500, Dan Williams wrote:
> On Thu, 2006-03-23 at 13:58 +0000, David Woodhouse wrote:
> > We aren't particularly good at noticing when 54Mbps connections aren't
> > reliable and backing down to slower speeds. This patch changes the
> > default to 11Mbps.
> >
> > It's possible we'd want to leave it like this anyway -- even when we can
> > handle dynamic rate adjustment, it might make sense to start at 11Mbps
> > and then tune it up or down from there, rather than starting at 54Mbps.
> >
> > Signed-off-by: David Woodhouse <[EMAIL PROTECTED]>
> >
> > --- linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_module.c~
> > 2006-03-21 23:50:00.000000000 +0000
> > +++ linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_module.c
> > 2006-03-22 11:00:57.000000000 +0000
> > @@ -183,7 +183,10 @@ void ieee80211softmac_start(struct net_d
> > */
> > if (mac->txrates_change)
> > oldrates = mac->txrates;
> > - if (ieee->modulation & IEEE80211_OFDM_MODULATION) {
> > + /* FIXME: We don't correctly handle backing down to lower rates,
> > + so start off at 11M for now. People can manually change it if
> > + they really need to, but 11M is more reliable. */
> > + if (0 && ieee->modulation & IEEE80211_OFDM_MODULATION) {
> > mac->txrates.default_rate = IEEE80211_OFDM_RATE_54MB;
> > change |= IEEE80211SOFTMAC_TXRATECHG_DEFAULT;
> > mac->txrates.default_fallback = IEEE80211_OFDM_RATE_24MB;
> > --- linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_wx.c~
> > 2006-03-21 23:50:00.000000000 +0000
> > +++ linux-2.6.16.ppc/net/ieee80211/softmac/ieee80211softmac_wx.c
> > 2006-03-22 12:11:58.000000000 +0000
> > @@ -136,7 +136,7 @@ ieee80211softmac_wx_set_rate(struct net_
> >
> > if (in_rate == -1) {
> > /* automatic detect */
> > - if (ieee->modulation & IEEE80211_OFDM_MODULATION)
> > + if (0 && ieee->modulation & IEEE80211_OFDM_MODULATION)
> > in_rate = 54000000;
> > else
> > in_rate = 11000000;
>
> Seems like the comment from hunk 1 should go there too. If I see a
> random if (0 &&...) in code somewhere then I've got no idea why just
> looking at the code.
Dan makes a good point. Ideally, the FIXME comments should refer to
each other as well.
I'm redoing the wireless-2.6 tree to back-out this patch. (I think
that is best, since I don't think Jeff has pulled it yet.)
Please do resubmit the patch w/ the comment changes. I'd also like
to see the outcome of the related discussion on the bcm43xx-dev list.
John
--
John W. Linville
[EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
