The most visible things: David Boggs <[EMAIL PROTECTED]> writes:
> I have totally rewritten the lmc wan device driver. > Directory drivers/net/wan/lmc and its 12 source > files are replaced by two files in drivers/net/wan. Not sure (that's your drivers and hardware) but you may consider letting the old driver stay for a while, to enable users to make a smooth transition. Especially if the old driver is working. It doesn't conform to the formatting rules (tab width = 8, brackets etc). I think you have to strip non-Linux code (massive amounts #defined out). Not sure why are you using syncppp both directly and with my generic HDLC (which, for PPP, uses syncppp). The same applies to "rawip". It only complicates code. sc->hdlcdev->proto.id in gen_hdlc_watchdog() is quite internal to generic HDLC. Why are you doing that? gen_hdlc_open(): + /* Generic-HDLC gets protocol params using copy_from_user(). + * This is a problem for a kernel-resident device driver. + * Luckily, PPP does not need any params so no copy_from_user(). + */ Obviously it gets parameters from userspace with copy_from_user(). Why do you want to interact with generic HDLC settings (PPP etc)? And if you really want it, why are you doing it in your driver instead of using existing ioctls from userspace (the ones which sethdlc uses)? -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
