On Mon, 20 Mar 2006 11:07:34 -0800 "Ron Mercer" <[EMAIL PROTECTED]> wrote:
> Stephen, > > Thank you for taking the time to review my driver. The feedback was > great. I will endeavor to bring it up to an A+. Please see my comments > below. > > > * Do nvram via ethtool > I am not sure what you mean here. The driver reads nvram to determine > the register settings for the chip. Do you mean I should expose the > parameters to the user for modification? > It seemed the only thing the private ioctl was used for was to get access to eeprom. There is already an interface in ethtool for that and it's easier that way. One other thing, you might look into loading firmware using the request_firmware interface from user space. This has the advantage of not including firmware in the kernel, which makes it easier from a legal and release point of view. It does make it slightly harder if there are driver version to firmware coupling issues and for diskless nodes. > > > > * Different from common usage: > > - Most net drivers use pci_alloc_consistent rather than > > dma_alloc_coherent in network drivers > This I wasn't sure about. I looked at a 2.6 driver porting document that > indicated dma_alloc_xxx was the way to go. I did notice that most > network drivers in the kernel were using pci_alloc_xxx. > > Look at Documentation/DMA-mapping.txt, it describes the pci_alloc_consitent usage. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
