Jeff Garzik <[EMAIL PROTECTED]> writes:

> Eric W. Biederman wrote:
>> There is no maintainer contact in the driver nor in the maintainers file.
>
>> It has clearly been bug fixed but simply didn't look like there
>> was a maintainer.
>
> Then you clearly did not look at all.  Simply running the command
>
>       git-whatchanged drivers/net/forcedeth.c
>
> would have shown you that NV has contributed gigabit support, s/g, TSO,
> checksumming, jumbo frame support, 64-bit support and irq mitigation support 
> in
> the recent past.  'less drivers/net/forcedeth.c' shows much the same thing, 
> but
> without attribution.

There are also things to cause doubt.  It looks like Manfred Spraul
has contributed about as many patches as Ayaz Abdulla.

The driver still contains weird things like:
        NvRegUnknownSetupReg6 = 0x008,
#define NVREG_UNKSETUP6_VAL             3
        NvRegUnknownSetupReg1 = 0xA0,
#define NVREG_UNKSETUP1_VAL     0x16070f
        NvRegUnknownSetupReg2 = 0xA4,
        NvRegUnknownSetupReg5 = 0x130,
#define NVREG_UNKSETUP5_BIT31   (1<<31)
        NvRegUnknownSetupReg3 = 0x13c,
#define NVREG_UNKSETUP3_VAL1    0x200010
        NvRegTxRxControl = 0x144,
        NvRegUnknownSetupReg4 = 0x184,
#define NVREG_UNKSETUP4_VAL     8

The driver has no mention of features like the hardware firewall
that is supposed to be a part of this NIC, not even to the point of
ensuring features like that are turned off.

>> Which bugzilla?  They seem to be very popular and everyone seems to
>> have their own.
>
> bugzilla.kernel.org, the official one.  The one that forwards bugs to LKML and
> related lists.  The one that Andrew Morton always points to.
>
> Come on, Eric, you are far more clueful than this.

Barely.  Each subset of the kernel community does things a little
differently, and the basic assumptions vary.  In any group I'm not in
there day to day working with I find what they assume and what I
assume are not always the same.  So I asked.  Probably badly because
of my frustration.

I'm actually overjoyed to find that it looks like nvidia has some
element of on-going maintenance of their driver and it wasn't just a
one or two time code drop.  

Hopefully that will even make it easier to track this near show
stopper problem we are seeing.

Eric
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to