On 3/14/06, Eric Dumazet <[EMAIL PROTECTED]> wrote: > Herbert Xu a écrit : > > On Tue, Mar 14, 2006 at 07:23:05AM +0100, Eric Dumazet wrote: > >> Hum, but then we need a new macro or prototype, because n->sp is not valid > >> > >> n->sp = secpath_get(skb->sp); > >> > >> would still miscompile, even if secpath_get() is a no-op > > > > How about just leaving sp in the structure unconditionally? > > > > Cheers, > > Well, the point of this patch is to shrink a little bit 'struct sk_buff' :)
> --- a/include/linux/skbuff.h 2006-03-13 18:30:21.000000000 +0100 > +++ b/include/linux/skbuff.h 2006-03-13 18:38:27.000000000 +0100 > @@ -243,7 +243,9 @@ > } mac; > > struct dst_entry *dst; > +#ifdef CONFIG_XFRM > struct sec_path *sp; > +#endif Humm, we're trying to avoid/remove ifdefs in structs as most of the users will use distro kernels where most (if not all) of these config options are enabled :-\ - Arnaldo - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
