Alexey Dobriyan wrote:
From: Eric Sesterhenn <[EMAIL PROTECTED]>
memset() is called before check.
Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]>
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
---
drivers/net/chelsio/espi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/drivers/net/chelsio/espi.c
+++ b/drivers/net/chelsio/espi.c
@@ -296,9 +296,7 @@ void t1_espi_destroy(struct peespi *espi
struct peespi *t1_espi_create(adapter_t *adapter)
{
- struct peespi *espi = kmalloc(sizeof(*espi), GFP_KERNEL);
-
- memset(espi, 0, sizeof(*espi));
+ struct peespi *espi = kzalloc(sizeof(*espi), GFP_KERNEL);
Seems sane and a bug fix, I'll merge.
It makes me wonder, though: anybody left at Chelsio that cares about
this driver? We haven't heard from Chelsio ever since the initial merge.
Are there actually users of this hardware out there?
Jeff
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
