On Thu, Mar 02, 2006 at 05:47:22PM -0800, David S. Miller ([EMAIL PROTECTED])
wrote:
> From: Evgeniy Polyakov <[EMAIL PROTECTED]>
> Date: Thu, 2 Mar 2006 15:17:31 +0300
>
> > + if (!netlink_has_listeners(dev->nls), group)
> > + return -ESRCH;
> > +
>
> Along with being nice to me, it also helps to actually test your
> patches before you submit them. Evgeniy, this, along with the fact
> that all of your patches do non-trivial things, are the reasons why I
> usually let your patches sit for a week before I take a look seriously
> at them.
>
> There is no way that code quoted above works.
100% my fault, I resent copypast from broken mail, the first one was correct.
I am sorry.
This one works.
--
Return -ESRCH from cn_netlink_send() when there are not listeners,
just as it could be done by netlink_broadcast().
Propagate netlink_broadcast() error back to the caller.
Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]>
diff --git a/Documentation/connector/connector.txt
b/Documentation/connector/connector.txt
index 57a314b..ad6e0ba 100644
--- a/Documentation/connector/connector.txt
+++ b/Documentation/connector/connector.txt
@@ -69,10 +69,11 @@ Unregisters new callback with connector
struct cb_id *id - unique connector's user identifier.
-void cn_netlink_send(struct cn_msg *msg, u32 __groups, int gfp_mask);
+int cn_netlink_send(struct cn_msg *msg, u32 __groups, int gfp_mask);
Sends message to the specified groups. It can be safely called from
-any context, but may silently fail under strong memory pressure.
+softirq context, but may silently fail under strong memory pressure.
+If there are no listeners for given group -ESRCH can be returned.
struct cn_msg * - message header(with attached data).
u32 __group - destination group.
diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c
index 505677f..89cc29f 100644
--- a/drivers/connector/connector.c
+++ b/drivers/connector/connector.c
@@ -97,6 +97,9 @@ int cn_netlink_send(struct cn_msg *msg,
group = __group;
}
+ if (!netlink_has_listeners(dev->nls, group))
+ return -ESRCH;
+
size = NLMSG_SPACE(sizeof(*msg) + msg->len);
skb = alloc_skb(size, gfp_mask);
@@ -111,9 +114,7 @@ int cn_netlink_send(struct cn_msg *msg,
NETLINK_CB(skb).dst_group = group;
- netlink_broadcast(dev->nls, skb, 0, group, gfp_mask);
-
- return 0;
+ return netlink_broadcast(dev->nls, skb, 0, group, gfp_mask);
nlmsg_failure:
kfree_skb(skb);
--
Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
