jamal wrote:
+
+/*
+ * Commands sent from userspace
+ * Not versioned. New commands should only be inserted at the enum's end
+ */
+
+enum {
+ TASKSTATS_CMD_UNSPEC, /* Reserved */
+ TASKSTATS_CMD_NONE, /* Not a valid cmd to send
+ * Marks data sent on task/tgid exit */
you should not call it NONE just because it is unidirectional
(kernel->user). You should check in the kernel if someone sends it from
user space and/or set a command flag etc.
Jamal,
Was just getting down to fixing this when I noticed that genl_msg_rcv will
return -EOPNOTSUPP for TASKSTATS_CMD_NONE since taskstats doesn't
register a .doit for that command.
So AFAIC, there's nothing that needs to be done by way of processing. Or
did you
mean just change the name of the command ?
--Shailabh
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
