On 2/21/06, Herbert Xu <[EMAIL PROTECTED]> wrote: > Actually, here is a better patch for your problem. We should really > be using the TOS when doing IPsec lookups: > > [IPSEC] Use TOS when doing tunnel lookups > > We should use the TOS because it's one of the routing keys. It also > means that we update the correct routing cache entry when PMTU occurs. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
Not using TOS for hash calculation in the routing cache doesn't mean that we will find incorrent routing cache entry - we could find such a cached entry not using TOS, but when we compare its fields including TOS with a packet's fields ip_route_input_slow() will do fib_lookup() in case of false comparision result. As I wrote before, the patch could only reduce number of routing cache hits. Am I wrong somewhere? Most important thing: the problem with TOS changed in the packet path and the returned in ICMP Frag Needed is affects not only IPSec, but all other types of traffic. -- Ilia Sotnikov - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
