On Wed, 2006-15-02 at 09:54 +0100, Patrick McHardy wrote: [..] > [PKT_SCHED]: Convert sch_red to a classful qdisc
This is the only one i have issues with (i.e ACK all the other ones)[1]. I can understand for a RED algorithm to have a set of parameters for a physical queue (even in the case of multiple virtual queues within a physical queue); What you have introduced is a single set of RED parameters for possibly many physical queues/classes. I am trying to make sense of what that means. In addition i am not sure if the idea of mucking around with "limit" as a signal to the kernel. My suggestion is you perhaps make this a new qdisc (and ensure multiple RED parameter sets - one per class) cheers, jamal [1]I have to put a disclaimer: I am always a stickler as far as RED is concerned (Thomas can testify to that) because it is very delicate (not the code rather the algorithm) and i have suffered a lot in the past getting those parameters tuned. There was a gent who was interested in putting together regression tests for RED but he keeps disappearing on us. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
