On Wed, Feb 08, 2006 at 06:35:27PM +0900, Horms wrote: > > [PATCH] Better fixup for the orinoco driver > > > > The latest kernel added a pretty ugly fix for the orinoco etherleak bug > > which contains bogus skb->len checks already done by the caller and causes > > copies of all odd sized frames (which are quite common) > > > > While the skb->len check should be ripped out the other fix is harder to do > > properly so I'm proposing for this the -mm tree only until next 2.6.x so > > that it gets tested. > > > > Instead of copying buffers around blindly this code implements a padding > > aware version of the hermes buffer writing function which does padding as > > the buffer is loaded and thus more cleanly and without bogus 1.5K copies. > > > > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> > > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> > > Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> > > The above is a patch included in 2.6.16 as a fix for CVE-2005-3180. It to > be applicable to 2.4. I have made a backport below, with the only > semi-significant change being including the ALIGN macro in orinoco.c, as it > doesn't exist in 2.4. > > As yet untested
Applied. In regard to testing: - similarity of 2.6 code guarantees certain testing coverage - v2.4.33 is in -pre stage, plenty of time for the fix to be on trial. Thanks Horms! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
