On Sunday 12 February 2006 11:59, Ivo van Doorn wrote:
> On Sunday 12 February 2006 01:10, Francois Romieu wrote:
> > Ivo van Doorn <[EMAIL PROTECTED]> :
> > [...]
> > > diff -U 3 -H -w -E -d -r -N --
> > > wireless-2.6/drivers/net/wireless/rt2x00/rt2400pci.c
> > > wireless-2.6-rt2x00/drivers/net/wireless/rt2x00/rt2400pci.c
> > > --- wireless-2.6/drivers/net/wireless/rt2x00/rt2400pci.c 2006-02-09
> > > 20:35:21.000000000 +0100
> > > +++ wireless-2.6-rt2x00/drivers/net/wireless/rt2x00/rt2400pci.c
> > > 2006-02-11 22:56:08.000000000 +0100
> > > @@ -2238,11 +2279,15 @@
> > > }
> > >
> > > #ifdef CONFIG_PM
> > > +static int rt2400pci_suspend(struct pci_dev *pci_dev, pm_message_t
> > > state);
> > > +static int rt2400pci_resume(struct pci_dev *pci_dev);
> > > +
> > > static int
> > > rt2400pci_suspend(struct pci_dev *pci_dev, pm_message_t state)
> >
> > The forward declaration of rt2400pci_suspend is not needed.
> >
> > > {
> > > struct net_device *net_dev = pci_get_drvdata(pci_dev);
> > > struct rt2x00_pci *rt2x00pci = ieee80211_dev_hw_data(net_dev);
> > > + int counter = 0;
> >
> > The initializer is not needed.
> >
>
> I will resend this patch with the forward declaration and initializer fixed.Perhaps it is better if instead of resending this patch, I will send a patch which fixes codingstyle issues: (space after "if" and "for", initializer and NULL checks before kfree()) IvD
pgpQZIHSnB2Te.pgp
Description: PGP signature
