From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Fri, 10 Feb 2006 10:39:14 +0000
> On Fri, Feb 10, 2006 at 06:25:33PM +0900, FUJITA Tomonori wrote: > > This is AF_PACKET mmap compat support. > > > > I confirmed that 32-bit and 64-bit tcpdump binaries using AF_PACKET > > mmap'ed pcap can dump packets properly with a 64-bit kernel. > > NACK. The 32bit test ifdefs are horrible. Please add fops->compat_mmap > instead. is_compat_task() is going into asm-*/compat.h eventually anyways, so ignore the ifdefs. They're only there because the interface isn't provided yet. I guess you haven't seen drivers/input/evdev.c where this same set of ifdefs already exist. Anyways, adding a compat layer file operations method would be a nice idea. But I think it might be a bit unreasonable that every person trying to simply fix a bug is expected to go out and create entirely new infrastructure. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
