Eric Dumazet wrote:
David S. Miller a écrit :

From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Wed, 08 Feb 2006 00:23:45 +0100

Some devices are *never* unregistered : loopback, or statically linked drivers, thus we are refcounting them for nothing.


Statically linked drivers can have netdev's that get unregistered
and free'd up.  For example we have a few cases where configuration
calls allocate/register and deallocate/unregister net devices.


Yes, e1000 currently does this, and I actually am using this patch on a machine with a e1000 card : I didnt change e1000 source.

I understand what you're trying to do, but I don't think this is
the way to do it.

What do you think about having no ref counting, and upon removal of
a network device, we notify each logic unit that deals with skbs
or other things that link to the netdev and ask it to clean all
references to the NIC in question?

I'm not sure how much fun this would be to code..but it would
at least force us to understand exactly what code holds netdev references,
and get rid of an atomic op or two in the hot path...

Ben

--
Ben Greear <[EMAIL PROTECTED]>
Candela Technologies Inc  http://www.candelatech.com

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to