On Thu, Jan 26, 2006 at 03:01:00PM -0800, Stephen Hemminger wrote: > > Well, it was before I changed del_nbp to set dev->br_port to NULL. > So what br_del_if would get called twice for same port.
Right. I wasn't questioning the zeroing of dev->br_port. I was just saying that placing a barrier using rcu_assign_pointer when you're setting it to NULL is useless because the mechanism that is required here is the quiescent state. On the other hand, when we set dev->br_port to a non-NULL value we do need the barrier. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
