On Fri, 20 Jan 2006, Sam Ravnborg wrote:

> With reference to latest discussions on linux-kernel with respect to
> inline here is a patch for tipc to remove all inlines as used in 
> the .c files. See also chapter 14 in Documentation/CodingStyle.
> 
> Before:
>    text          data     bss     dec     hex filename
>  102990          5292    1752  110034   1add2 tipc.o
> 
> Now:
>    text          data     bss     dec     hex filename
>  101190          5292    1752  108234   1a6ca tipc.o
> 
> This is a nice text size reduction which will improve icache usage.
> In some cases bigger (> 4 lines) functions where declared inline
> and used in many places, they are most probarly no longer inlined by gcc
> resulting in the size reduction.
> There are several one liners that no longer are declared inline, but gcc
> should inline these just fine without the inline hint.

I've applied this in my tree as well. Initial tests show no problems.

> With this patch applied one warning is added about an unused static
> function - that was hidded by utilising inline before.
> The function in question were kept so this patch is solely a
> inline removal patch.

I've removed those.

Thanks Sam!

/Per
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to