On Sat, Jan 07, 2006 at 03:22:43AM +0100, Francois Romieu wrote:
> The unlocking disappeared during commit
> 5793f4be23f0171b4999ca68a39a9157b44139f3.
>
> Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>
>
> diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c
> index 3e9accf..41b3d83 100644
> --- a/drivers/net/hamradio/mkiss.c
> +++ b/drivers/net/hamradio/mkiss.c
> @@ -524,6 +524,7 @@ static void ax_encaps(struct net_device
> ax->dev->trans_start = jiffies;
> ax->xleft = count - actual;
> ax->xhead = ax->xbuff + actual;
> + spin_unlock_bh(&ax->buflock);
> }
>
> /* Encapsulate an AX.25 packet and kick it into a TTY queue. */
No, with your patch the spinlock is dropped only after the
tty->driver->write() call which might sleep.
Ralf
Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]>
Index: net.git/drivers/net/hamradio/mkiss.c
===================================================================
--- net.git.orig/drivers/net/hamradio/mkiss.c
+++ net.git/drivers/net/hamradio/mkiss.c
@@ -515,6 +515,7 @@ static void ax_encaps(struct net_device
count = kiss_esc(p, (unsigned char *)ax->xbuff, len);
}
}
+ spin_unlock_bh(&ax->buflock);
set_bit(TTY_DO_WRITE_WAKEUP, &ax->tty->flags);
actual = ax->tty->driver->write(ax->tty, ax->xbuff, count);
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
