From: "Gabor Fekete" <[EMAIL PROTECTED]> Date: Tue, 29 Nov 2005 13:18:28 -0800
> I realized that in fib_rules.c the inet_rtm_new_rule() > function adds rules without checking if they already > exist. This may result in duplicate rules being added. > It makes it difficult to remove a rule when it is > added multiple times (with the intention that it would > be added only once if it exists, setting the necessary > netlink flags). > The attached patch tries to fix this. Sorry for attaching > but my email client screws tabs. > It is against 2.6.11 but it is the case with 2.6.14.3 too, > as I see. > > Signed-off-by: Gabor Fekete <[EMAIL PROTECTED]> I can see what you're doing here, but I'm not so sure this plays well with the preference field. The preference field is meant to act the same way a firewall chain does. You can have identical rules in the chain, and the preference determines which one gets actually hit. But the exclusive flag in the netlink message indicates that we should disallow multiple rules with the same key. I'm inclined to apply this patch, but does anyone have any strong opinions either way? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
