On 12/19/05, Randy.Dunlap <[EMAIL PROTECTED]> wrote:
> On Mon, 19 Dec 2005, John W. Linville wrote:
>
> > On Mon, Dec 19, 2005 at 04:43:51PM +0100, Lennert Buytenhek wrote:
> > > On Mon, Dec 19, 2005 at 10:09:32AM -0500, John W. Linville wrote:
> > >
> > > > > > @@ -633,7 +643,7 @@ static int __devinit sundance_probe1 (st
> > > > > >
> > > > > > np->phys[0] = 1; /* Default setting */
> > > > > > np->mii_preamble_required++;
> > > > > > - for (phy = 1; phy <= 32 && phy_idx < MII_CNT; phy++) {
> > > > > > + for (phy = 0; phy < 32 && phy_idx < MII_CNT; phy++) {
> > > > > > int mii_status = mdio_read(dev, phy, MII_BMSR);
> > > > > > int phyx = phy & 0x1f;
> > > > > > if (mii_status != 0xffff && mii_status != 0x0000) {
> > > > >
> > > > > (Your PHY is at address 0?) Can you add some debug here to see what
> > > > > happens in both cases (f.e. print the returned MII_BMSR values for
> > > > > both 'start at 0' and 'start at 1')? Presumably there's something
> > > > > about starting at 1 that gets your hardware confused, I'd like to know
> > > > > what that is..
> > > >
> > > > How about if you just ditch that hunk?
> > >
> > > Sorry, I should have mentioned: Arnaldo told me (on IRC) that it
> > > doesn't detect the transceiver without this hunk.
> >
> > Hmmm...that seems odd. Of course, that is the way I had it before
> > Jeff told me to change it to probe PHY ID 0 last... :-)
>
> Many years ago, when I worked on network drivers, (iirc)
> PHY 0 was to be used only if no other PHYs were present,
> so it should be checked last, not first.
Hey, I should start the Janitor's Driver Development Documentation
Project, would ya lemme a hand? 8)
Humm, actually I guess these useful bits of information can find a
home at http://linux-net.osdl.org 8)
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
