On 12/11/05, Francois Romieu <[EMAIL PROTECTED]> wrote:
> Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> :
> [...]
> index 0000000..23058dc
> --- /dev/null
> +++ b/net/dccp/ipv6.c
> [...]
> +static void dccp_v6_ctl_send_reset(struct sk_buff *rxskb)
> +{
> [...]
> +       skb = alloc_skb(MAX_HEADER + sizeof(struct ipv6hdr) +
> +                       dccp_hdr_reset_len, GFP_ATOMIC);
> +       if (skb == NULL)
> +               return;
> [...]
> +       /* sk = NULL, but it is safe for now. RST socket required. */
> +       if (!ip6_dst_lookup(NULL, &skb->dst, &fl)) {
> +
> +               if ((xfrm_lookup(&skb->dst, &fl, NULL, 0)) < 0)
> +                       return;
>
> skb leak ?
>
> Same pattern in dccp_v6_ctl_send_ack/tcp_v6_send_{ack/reset}.

Good spot, chatted with Dave and will resend [1/4] with a fix for this
and 5/5 with the fix for the tcp_v6 ones, without resending [2/[2..4]],
thanks!

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to