On Tue, Nov 15, 2005 at 07:46:58AM +1100, Herbert Xu wrote: > John W. Linville <[EMAIL PROTECTED]> wrote: > > > > diff --git a/drivers/net/wan/pc300_tty.c b/drivers/net/wan/pc300_tty.c > > index 52f26b9..931cbdf 100644 > > --- a/drivers/net/wan/pc300_tty.c > > +++ b/drivers/net/wan/pc300_tty.c > > @@ -689,7 +689,7 @@ static void cpc_tty_rx_work(void * data) > > } > > } > > cpc_tty->buf_rx.first = > > cpc_tty->buf_rx.first->next; > > - kfree(buf); > > + kfree((void *)buf); > > buf = cpc_tty->buf_rx.first; > > flg_rx = 1; > > Someone should audit the entire driver and make sure it has the > correct serialisation primitives. After that just remove the > volatile keywords. > > For now please leave it in as a reminder for someone to do this.
Excellent point...I ratify that suggestion! John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
