ppp ioctls handlers in parisc are wrong:

 - they would need to do a copat_ptr on  ifr->ifr_ifru.ifru_data
 - SIOCGPPP* ioctls are defines as SIOCDEVPRIVATE + n, so they'd
   kick in for all private ioctls which is defintely wrong.

to implement proper ppp compat_ioctl handlig we'd need a compat_ioctl
method in struct net_device, which we don't have yet.


Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>

Index: linux-2.6/arch/parisc/kernel/ioctl32.c
===================================================================
--- linux-2.6.orig/arch/parisc/kernel/ioctl32.c 2005-11-12 02:07:44.000000000 
+0100
+++ linux-2.6/arch/parisc/kernel/ioctl32.c      2005-11-12 02:08:06.000000000 
+0100
@@ -38,9 +38,6 @@
 #include "compat_ioctl.c"
 
 /* And these ioctls need translation */
-HANDLE_IOCTL(SIOCGPPPSTATS, dev_ifsioc)
-HANDLE_IOCTL(SIOCGPPPCSTATS, dev_ifsioc)
-HANDLE_IOCTL(SIOCGPPPVER, dev_ifsioc)
 
 IOCTL_TABLE_END
 
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to