> Do you have a test case that demonstrates this? It appears to > me that an MLDv2 general query doesn't execute that code (short circuited > above) and an MLDv1 general query (what that code is handling) will > have a timer expiring before switching back to MLDv2 mode (so it'll send > a v1 report, without any sources). Unless I'm missing something, I can't > see any way for the scenario you've described to happen. > That said, I also can't see anything it would hurt, so I don't > object, > but it looks unnecessary to me. > > +-DLS > >
>MLDv2 general query doesn't execute that code Yes, MLDv2 general query also leave that bit unchanged. In MLDv1 compatibility mode, igmp6_timer_handler(...) uses igmp6_send(...) to send report, it leaves that bit unchanged too. So when switching back to MLDv2 mode, MAF_GSQUERY flag set long time ago may have effect on the report . >That said, I also can't see anything it would hurt I agree with you. it hurts nothing but a report. By the way. May I ask a question. Do you agree my change on is_in(...)? That is check include/exclude count when type is MLD2_MODE_IS_INCLUDE or MLD2_MODE_IS_EXCLUDE. (especially for MLD2_MODE_IS_EXCLUDE) Regards - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
