On Tue, 2005-09-06 at 12:24 +0100, Christoph Hellwig wrote:
> > +#ifdef __IN_PCMCIA_PACKAGE__
> > +#include <pcmcia/k_compat.h>
> > +#endif /* __IN_PCMCIA_PACKAGE__ */
>
> this doesn't make sense for a 2.6 driver.
Fixed in my tree, thanks. Patches will be sent shortly.
> > +#ifdef SPECTRUM_FW_INCLUDED
> > +/* Header with the firmware */
> > +#include "spectrum_fw.h"
> > +#else /* !SPECTRUM_FW_INCLUDED */
>
> While I see the point of this for the standalone orinoco driver package
> it doesn't make sense for the version in the kernel tree.
Likewise.
>
> > +#define CS_CHECK(fn, ret) \
> > + do { last_fn = (fn); if ((last_ret = (ret)) != 0) goto cs_failed; }
> > while (0)
>
> I don't think this macro abuse helps anyone..
Sure, but it's abused by many drivers. Maybe next time.
--
Regards,
Pavel Roskin
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
