Hi,
Herbert Xu napisał(a):
On Thu, Sep 08, 2005 at 01:31:26PM -0700, David S. Miller wrote:
From: Dave Hansen <[EMAIL PROTECTED]>
Date: Thu, 08 Sep 2005 07:02:17 -0700
KERNEL: assertion ((int)tp->lost_out >= 0) failed at net/ipv4/tcp_input.c (2148)
So tp->lost_out went negative, didn't we discuss to death last week
how this was impossible? :-)
We certainly did :) However, the already sent test in tcp_fragment()
is off by one which probably explains these crashes. This patch should
help.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
Cheers,
------------------------------------------------------------------------
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -499,7 +499,7 @@ int tcp_fragment(struct sock *sk, struct
/* If this packet has been sent out already, we must
* adjust the various packet counters.
*/
- if (after(tp->snd_nxt, TCP_SKB_CB(buff)->end_seq)) {
+ if (!before(tp->snd_nxt, TCP_SKB_CB(buff)->end_seq)) {
int diff = old_factor - tcp_skb_pcount(skb) -
tcp_skb_pcount(buff);
kernel: 2.6.13-git9 (with Herbert's patch)
It is the same situation as before (Andrew Morton has forwarded my
previus e-mail).
It appears when I try to download gnome-2.12 from bittorrent. I tried to
download openoffice from bt and everything was ok.
Sep 9 17:25:32 ng02 kernel: KERNEL: assertion ((int)tp->lost_out >= 0)
failed at net/ipv4/tcp_input.c (2148)
Sep 9 17:25:32 ng02 kernel: Leak l=4294967295 4
Sep 9 18:12:42 ng02 kernel: KERNEL: assertion ((int)tp->lost_out >= 0)
failed at net/ipv4/tcp_input.c (2148)
Sep 9 18:12:42 ng02 kernel: Leak l=4294967295 4
Sep 9 18:19:58 ng02 kernel: KERNEL: assertion ((int)tp->lost_out >= 0)
failed at net/ipv4/tcp_input.c (2148)
Sep 9 18:19:58 ng02 kernel: Leak l=4294967295 3
Regards,
Michal Piotrowski
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
