From: Julian Anastasov <[EMAIL PROTECTED]>
Date: Thu, 8 Sep 2005 10:01:39 +0300 (EEST)

>       One such place that can damage the dst refcnts is route.c
> with CONFIG_IP_ROUTE_MULTIPATH_CACHED enabled, i don't see the user's
> .config. In this new code i see that rt_intern_hash is called before
> dst->refcnt is set to 1, dst is the 2nd arg to rt_intern_hash.
> Arg 2 of rt_intern_hash must come with refcnt 1 as it is added to
> table or dropped depending on error/add/update. One such example
> is ip_mkroute_input where __mkroute_input return rth with refcnt 0
> which is provided to rt_intern_hash. ip_mkroute_output looks like
> a 2nd such place. Appending untested patch for comments and review.
> The idea is to put previous reference as we are going to return
> next result/error.
> 
> Signed-off-by: Julian Anastasov <[EMAIL PROTECTED]>

Although this bug should be fixed, the multipath-cached
stuff can oops a machine in a thousand other ways as well
and should be disabled in general.  That's why it's marked
EXPERIMENTAL at the moment, until someone goes in and fixes
it up properly.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to