David S. Miller wrote:
From: Ben Greear <[EMAIL PROTECTED]>
Date: Wed, 07 Sep 2005 12:36:20 -0700
Thanks for catching that. A new patch is attached. I didn't see any
printouts for this message even with the fix, so this case must not be
hit (at least not often).
Please let me know if you see any more areas for improvement.
Doing an add_timer() for something already scheduled it fine.
Does it actually cause a second timer to fire? If not, this
would keep us from correctly decrementing the reference count.
Perhaps, the add_timer() calls should be changed with a sequence that
finds the shortest of the currently scheduled timer and the desired
new one, and invoke mod_timer() based upon that.
That sounds good to me, but how would the original code handle it?
Ie, when you call add_timer while the timer is already added,
did it choose the shortest time, or the longest?
Oh, please stop doing this to every file you touch:
@@ -1,4 +1,4 @@
-/*
+/* -*- linux-c -*-
That allows me to keep the formatting correct (ie, tabs not spaces, etc)
when editing in Emacs. Please don't make me take these out!
Ben
--
Ben Greear <[EMAIL PROTECTED]>
Candela Technologies Inc http://www.candelatech.com
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
