On Mon, Sep 05, 2005 at 10:55:58PM +0400, Alexey Dobriyan wrote:
> * usual s/u32/__be32/.
> * add svc_getnl(), svc_putnl() in spirit of svc_getu32(), svc_putu32().
>   They return and accept __be32 instead of __u32, respectively.
> * convert to svc_getnl(), svc_putnl().

Umm...  I'm not particulary happy with the names.  "nl" for "net long"?

> -     svc_putu32(rqstp->rq_res.head, htonl(RPC_AUTH_GSS));
> +     svc_putnl(rqstp->rq_res.head, htonl(RPC_AUTH_GSS));

... and this is another problem - this sort of things is _way_ too frequent,
so I really wonder if we should have a separate helper for - if it's inlined,
there would be no problem with constants.  I.e. have a helper that would
take host-order integer and shove htonl() of it into buffer.

Are there any svc_putu32() left after that patch, BTW?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to