jamal wrote:
Was this a patch you sent? I also had to stare at it for a minute ..
Yes.
There is no need to check for NULL; if you got that far dev cannot be
NULL (refer to the first check for parm->ifindex). The device could not
have disapeared since we are protected by rtnl semaphore.
It doesn't check for the new device, it checks whether an old device
needs to be released. This can't be done unconditionally since dev_put
doesn't handle NULL pointers.
BTW, since you're hunting for leaked device references, the mirred
action should register to the netdev notifier to kill actions holding
device references when the device goes down, no? Jamal?
Thinking .. thinking ..thinking..
Ok, devices disappearing imply classifiers will remove/destroy the
action as well... never mind, the device referenced by the by mirred is
mostly not the same as where we attached...
You are right - did you mean NETDEV_UNREGISTER notification only,
correct?
Correct.
Please send a patch I am tied up or i could do it probably this
weekend (I am worried i may forget about but the patch should be
simple).
How do you propose to react? Kill the action or set the device
to NULL and handle it in tcf_mirred()?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
