Can you please at least _COMPILE_ the patches you post
so that my time isn't wasted like this?
include/linux/ethtool.h:259: error: two types specified in one empty declaration
Of course, you missed the semi-colon:
+struct ethtool_perm_addr {
+ u32 cmd; /* ETHTOOLGPERMADDR */
+ int size;
+ char data[0];
+}
+
But even with that fixed:
include/linux/ethtool.h:271: warning: "struct ethtool_addr" declared inside
parameter list
include/linux/ethtool.h:271: warning: its scope is only this definition or
declaration, which is probably not what you want
+int ethtool_op_get_perm_addr(struct net_device *dev, int len,
+ struct ethtool_addr *addr);
You probably meant ethtool_perm_addr as the type for that parameter.
This patch wasn't even put through basic smoke tests such as
_COMPILING_ it, otherwise these obvious errors would have been caught
patch submission.
I'm really upset because this kind of stuff wastes a lot of my
time.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
