Agreed, we will roll in this in our next build
-Malli
-----Original Message-----
From: Ingo Oeser [mailto:[EMAIL PROTECTED]
Sent: Tuesday, August 09, 2005 3:27 AM
To: Chilakala, Mallikarjuna
Cc: [EMAIL PROTECTED]; netdev
Subject: Re: [RESEND][PATCH net-drivers-2.6 5/9] ixgb: Fix data output
by ethtool -d
Hi Malli,
Malli Chilakala wrote:
> Fix data output by ethtool -d
>
> Signed-off-by: Mallikarjuna R Chilakala
<[EMAIL PROTECTED]>
> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
> Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
>
> diff -up netdev-2.6/drivers/net/ixgb/ixgb_ethtool.c
> netdev-2.6/drivers/net/ixgb.new/ixgb_ethtool.c ---
> netdev-2.6/drivers/net/ixgb/ixgb_ethtool.c 2005-08-05
09:25:28.000000000
> -0700 +++ netdev-2.6/drivers/net/ixgb.new/ixgb_ethtool.c
2005-08-05
> 09:25:38.000000000 -0700 @@ -301,7 +301,8 @@ ixgb_get_regs(struct
> net_device *netdev,
> *reg++ = IXGB_READ_REG(hw, RAIDC); /* 19 */
> *reg++ = IXGB_READ_REG(hw, RXCSUM); /* 20 */
>
> - for (i = 0; i < IXGB_RAR_ENTRIES; i++) {
> + /* there are 16 RAR entries in hardware, we only use 3 */
> + for(i = 0; i < 16; i++) {
Please define a symbol for this constant somewhere. Introducing
hardcoded values are a regression in readability.
Suggested symbol: "#define IXGB_ALL_RAR_ENTRIES 16"
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
