On Wed, Aug 03, 2005 at 12:19:24PM -0300, Arnaldo Carvalho de Melo wrote: > On 8/3/05, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > On Wed, Aug 03, 2005 at 06:29:25AM -0700, David S. Miller wrote: > > > From: Eric Dumazet <[EMAIL PROTECTED]> > > > Date: Tue, 02 Aug 2005 23:45:27 +0200 > > > > > > > Please move ; in a better place, not > > > > just after spinlock_t portalloc_lock; > > > > > > [ Eric, I haven't had time to respond to this thread because I'm > > > in the UK for UKUUG2005 this week, so email access is sporadic] > > > > > > Please use __read_mostly attribute to achieve this. > > > > > > The linker can otherwise arrange the data section symbols > > > however it likes, and therefore placing it in some specific > > > spot in some C file makes no guarentees where it'll end up > > > in the final image. > > > > > > Section attributes, such as __read_mostly, are the only way to > > > make guarentees about symbol placement. > > > > Umm, that's inside a dynamically allocated structure. __read_mostly > > doesn't do anything in that case. > > No, as of now it is on a static structure, in the same way tcp_hashifo has > been > sitting in ./net/ipv4/tcp_ipv4.c for aeons 8)
okay, sorry for the confusion, I should have looked at it more closely. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
