On Tue, 2 Aug 2005, Sridhar Samudrala wrote:

> On Fri, 2005-07-29 at 03:53 +0400, Alexey Dobriyan wrote:
> > * Use __be16, __be32.
> > * Add SCTP_NL() in the spirit of SCTP_U32() and friends.
> > * Tiny tweak in sctp_chunk_assign_ssn().
>
> How do we run sparse to check for endian errors?
> I tried make C=1 net/sctp/sctp.ko, but i didn't see any
> endian warnings.

Hi,

You have to enable -Wbitsize , it's not a default option.
See Documentation/sparse.txt or use something like this:

make C=1 CHECK='~/bin/sparse -Wbitsize' all

and I send output to a disk file for easier reading. :)

> But your changes look fine.
>
> Thanks
> Sridhar
>
> >
> > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
> > ---
> >
> >  include/linux/sctp.h       |   60 
> > ++++++++++++++++++++++-----------------------
> >  include/net/sctp/command.h |    2 +
> >  include/net/sctp/sctp.h    |    2 -
> >  include/net/sctp/sm.h      |    6 ++--
> >  include/net/sctp/structs.h |    4 +--
> >  include/net/sctp/tsnmap.h  |    4 +--
> >  include/net/sctp/user.h    |    2 -
> >  net/sctp/associola.c       |    2 -
> >  net/sctp/ipv6.c            |    4 +--
> >  net/sctp/outqueue.c        |    2 -
> >  net/sctp/protocol.c        |    2 -
> >  net/sctp/sm_make_chunk.c   |   31 +++++++++++------------
> >  net/sctp/sm_statefuns.c    |   10 +++----
> >  net/sctp/ulpevent.c        |    2 -
> >  14 files changed, 67 insertions(+), 66 deletions(-)

-- 
~Randy
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to