Jesse Brandeburg wrote:
Please don't apply this patch, we need the NETIF_MSG_LINK messages to
be printed because most everyone likes to know when their link came
up/went down.
Then your driver need to be more explicit with it. Some other people
will think this is a bug, even more because currently you need the
source of the driver in order to understand what value you have to pass
to the debug= parameter to get the desired debug output.
Another drawback of your approach is that it "cummulative", if I set
debug=13 I get in fact output for almost all flags, which might be a lot.
Why not pass the flags directly (e. g. debug=0x11ff)?
But I understand your point, and in fact I am interested in link up/down
messages too :).
/holger
--
Holger Eitzenberger <[EMAIL PROTECTED]> | Kernel Developer
Astaro AG | www.astaro.com | Phone +49-721-25516-246 | Fax -200
Documentation: http://docs.astaro.org
User Bulletin Board: http://www.astaro.org
- Certified by ICSA labs - June 2004
- Computer Reseller News: "CRN Certified Program" - June 2004
- Linux Pro Italy: Best Rating 10 out of 10 points - May 2004
- Linux Enterprise Readers' Choice Award: Best Firewall -- October 2003
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
