From: Thomas Graf <[EMAIL PROTECTED]>
Date: Mon, 25 Jul 2005 22:16:21 +0200
> * David S. Miller <[EMAIL PROTECTED]> 2005-07-25 13:14
> > We removed INPUT_DEV from the meta ematch last week remember?
>
> Sure, but we can readd it once its clear how it will be used.
> What I meant is that the meta ematch doesn't care as it will
> provide access by name and by ifindex anyway.
I see.
I was also just thinking about the semantic change that will
result if rules are specified by device name, and we start
doing match comparisons using ifindex. I don't think we can
legally do things that way.
If a device goes down, and comes back up with the same name
but a different ifindex, we should still match it with existing
rules based upon name. So we'd end up with stuff like:
dev = dev_get_by_index(ifindex);
match = 0;
if (!strcmp(p->name, dev->name))
match = 1;
dev_put(dev);
at which point we might as well just grab a device reference in
skb->input_dev since that's simpler and a lot cheaper and easier to
verify.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
