* Patrick McHardy <[EMAIL PROTECTED]> 2005-07-17 04:09
> Kill skb->tc_classid. It leaves a hole on 64 bit machines, I didn't
> try to plug it since with all the planned changes we probably need
> some restructuring at the end anyway.

I have no objections to this, looks perfectly
fine to me.

> @@ -535,7 +530,6 @@ static struct meta_ops __meta_ops[TCF_ME
>               [META_ID(TCINDEX)]              = META_FUNC(int_tcindex),
>  #ifdef CONFIG_NET_CLS_ACT
>               [META_ID(TCVERDICT)]            = META_FUNC(int_tcverd),
> -             [META_ID(TCCLASSID)]            = META_FUNC(int_tcclassid),


I used to mark such ids as obsolete in the header but since
skb is on diet anyway and there has been no official
iproute2 release with the ematch bits included it might be
a better idea to remove the ids from the header completely.
Those that have picked up my patch on netdev shouldn't care
about a ABI breakage, actually I doubt that someone is using
it already.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to