On Fri, 2005-07-08 at 21:42 -0700, David S. Miller wrote: > > > BTW, the rest of the SCTP input path should be audited to make sure > > > any other use of the SKB control block on input does not spam the > > > ipv4/ipv6 parameter area (struct inet_skb_parm and struct > > > inet6_skb_parm). That must be preserved on input (unless you > > > unshare the SKB of course). That's why TCP's skb control block > > > (in net/tcp.h) uses this header as well. > > > > We do a skb_clone() before using the SKB control block to store > > the ulpevent structure, so i guess it should be OK. > > Aha! Now if you add the proper header to the front of > the ulpevent, you will not need to clone SKBs at all.
An incoming skb can contain more than 1 user message(chunk) and we do a clone for each message and store the per-message information in the ulpevent structure. Moreover, the ulpevent structure is already 34 bytes which makes it impossible to share the 40-byte control block with ip specific info. Thanks Sridhar - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
