On Fri, 3 Apr 2026 16:28:06 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> src/java.base/share/classes/java/security/cert/X509Certificate.java line 175: >> >>> 173: * Checks that the given instant is within the certificate's >>> 174: * validity period. In other words, this determines whether the >>> 175: * certificate would be valid at the given date/time. >> >> I think we can just say "the given instant". > > I wanted to keep the `date/time` here as it seemed to me to be easier to read > than repeating `instant`. Just wanted to keep it in clarification. > > If you still think it's better to make it `instant` - I don't mind changing I was thinking that back when `checkValidaty(Date)` was introduced, the author used `date` to match the argument type, but then thought it's not precise enough and added `time`. Now we don't have this inconvenience. Just my guess. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30047#discussion_r3033801154
