On Thu, 2 Apr 2026 12:15:37 GMT, SendaoYan <[email protected]> wrote:
>> Daisuke Yamazaki has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains three commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into
>> 8372325-http-client-tests-cleanup
>>
>> # Conflicts:
>> #
>> test/jdk/java/net/httpclient/HttpRequestBodyPublishers/FromPublisherTest.java
>> # test/jdk/java/net/httpclient/HttpRequestBodyPublishers/NoBodyTest.java
>> #
>> test/jdk/java/net/httpclient/HttpRequestBodyPublishers/OfByteArrayTest.java
>> #
>> test/jdk/java/net/httpclient/HttpRequestBodyPublishers/OfByteArraysTest.java
>> # test/jdk/java/net/httpclient/HttpRequestBodyPublishers/OfFileTest.java
>> #
>> test/jdk/java/net/httpclient/HttpRequestBodyPublishers/OfInputStreamTest.java
>> # test/jdk/java/net/httpclient/HttpRequestBodyPublishers/OfStringTest.java
>> - Update copyright year to 2026
>> - 8372325: Refactor tests under jdk/java/net/httpclient classes to use
>> ${test.main.class}
>
> test/jdk/java/net/httpclient/HttpClientExceptionTest.java line 42:
>
>> 40: * @bug 8248006
>> 41: * @summary The test checks if UncheckedIOException is thrown
>> 42: * @build HttpClientExceptionTest
>
> Hi. does `@build HttpClientExceptionTest` can replaced as `@build
> ${test.main.class}`
I'd prefer not to touch the build clause even if that were possible
> test/jdk/java/net/httpclient/HttpClientExceptionTest.java line 43:
>
>> 41: * @summary The test checks if UncheckedIOException is thrown
>> 42: * @build HttpClientExceptionTest
>> 43: * @run junit/othervm
>> -Djava.nio.channels.spi.SelectorProvider=HttpClientExceptionTest$CustomSelectorProvider
>
> Hi, does
> `-Djava.nio.channels.spi.SelectorProvider=HttpClientExceptionTest$CustomSelectorProvider`
> can replaced as
> `-Djava.nio.channels.spi.SelectorProvider=${test.main.class}$CustomSelectorProvider`
Please let's not do that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30307#discussion_r3027794155
PR Review Comment: https://git.openjdk.org/jdk/pull/30307#discussion_r3027789382
