> Can I please get a review of this change which proposes to address the issue > noted in https://bugs.openjdk.org/browse/JDK-8373778? > > When a CONNECT request to a proxy returns an invalid status line, then the > current code in the internal implementation of `HttpURLConnection` runs into > an exception trying to parse that status line. That exception propagates as > an unspecified `java.util.NoSuchElementException` to the application. > > The commit in this PR addresses it by doing additional checks on the status > line to ensure it is valid and if it isn't then it raises an `IOException`. > This is the same `IOException` that would have been raised for a few other > invalid responses for a CONNECT request. > > A new jtreg test has been introduced to reproduce the issue and verify the > fix. tier1, tier2, tier3 testing succeeded with this change.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision: Volkan's review - update test ------------- Changes: - all: https://git.openjdk.org/jdk/pull/30466/files - new: https://git.openjdk.org/jdk/pull/30466/files/b793c589..4bb1264b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=30466&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=30466&range=02-03 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/30466.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/30466/head:pull/30466 PR: https://git.openjdk.org/jdk/pull/30466
