On Mon, 23 Mar 2026 14:48:51 GMT, EunHyunsu <[email protected]> wrote:
>> When `expiryDate2DeltaSeconds()` fails to parse the Expires attribute >> against all date formats, it returns 0. The caller in >> `assignMaxAgeAttribute()` then sets `maxAge=0`, which causes `hasExpired()` >> to return true. Per RFC 6265 section 5.2.1, an unparseable Expires value >> should be ignored, leaving `maxAge=-1` (session cookie). >> >> This fix introduces a sentinel constant (`Long.MIN_VALUE`) as the return >> value for parse failure, since 0 is a valid delta for dates that match the >> creation time. The caller checks for this sentinel and skips the maxAge >> assignment when parsing fails. >> >> A new test in `MaxAgeExpires` verifies that unparseable Expires values are >> correctly ignored. > > EunHyunsu has updated the pull request incrementally with one additional > commit since the last revision: > > 8380549: Refactor expiryDate2DeltaSeconds to return Calendar test/jdk/java/net/CookieHandler/B6791927.java line 2: > 1: /* > 2: * Copyright (c) 2009, 2019, Oracle and/or its affiliates. All rights > reserved. Suggestion: * Copyright (c) 2009, 2026, Oracle and/or its affiliates. All rights reserved. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30341#discussion_r2979908422
