On Fri, 20 Mar 2026 09:03:04 GMT, Daniel Fuchs <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Verify if `ofByteArrays` is replayable > > test/jdk/java/net/httpclient/HttpRequestBodyPublishers/FromPublisherTest.java > line 115: > >> 113: } >> 114: >> 115: } > > Nit: could be nice to import `HttpRequest.BodyPublisher` and > `HttpRequest.BodyPuBlishers` to reduce the line lengths. Changed as requested in a49f120d09d. > test/jdk/java/net/httpclient/HttpRequestBodyPublishers/OfByteArrayTest.java > line 2: > >> 1: /* >> 2: * Copyright (c) 2026, Oracle and/or its affiliates. All rights reserved. > > should this be 2025, 2026? > Suggestion: > > * Copyright (c) 2025, 2026, Oracle and/or its affiliates. All rights > reserved. Changed as requested in a49f120d09d. > test/jdk/java/net/httpclient/HttpRequestBodyPublishers/OfFileChannelTest.java > line 2: > >> 1: /* >> 2: * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved. > > Suggestion: > > * Copyright (c) 2025, 2026, Oracle and/or its affiliates. All rights > reserved. Changed as requested in a49f120d09d. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30219#discussion_r2965408991 PR Review Comment: https://git.openjdk.org/jdk/pull/30219#discussion_r2965409527 PR Review Comment: https://git.openjdk.org/jdk/pull/30219#discussion_r2965409940
