On Wed, 11 Mar 2026 13:38:58 GMT, Jaikiran Pai <[email protected]> wrote:

>> test/jdk/com/sun/nio/sctp/SctpChannel/Bind.java line 26:
>> 
>>> 24: /* @test
>>> 25:  * @bug 4927640
>>> 26:  * @requires (os.family == "linux")
>> 
>> This test will does the environment support SCTP ot not by 
>> `Util.isSCTPSupported()`. Test will throw skippedException if it do not 
>> support SCTP. So the additional `@requires (os.family == "linux")` seems do 
>> not needed
>
> Hello @sendaoYan ,I haven't yet reviewed the changes, but a reply just to 
> this specific part - the `@requires` can be useful to prevent the test from 
> even being picked up for execution if it doesn't match the expected 
> `@requires`. What it means is that it can potentially prevent launching a 
> java process (for example) just to have the test then throw a 
> `SkippedException`. So `@requires` can help if you know beforehand that a 
> particular platform isn't expected to support SCTP.

Although Windows and macOS do not natively support SCTP, maybe it possible to 
achieve SCTP protocol support on Windows or macOS by installing third-party 
libraries. I'am not sure,

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30186#discussion_r2918465146

Reply via email to