On Thu, 3 Nov 2022 18:13:34 GMT, Daniel Fuchs <[email protected]> wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8288717: IdleConnectionTimeout can use Keep Alive or Custom Value
>
> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java
> line 1708:
>
>> 1706: if (s != null) {
>> 1707: long timeoutVal = Long.parseLong(s);
>> 1708: System.err.println(timeoutVal);
>
> Stray println? You could use `Log.logTrace` here to print the value.
Gah, thought I zapped all of these! Thanks for spotting. I think there is no
need to log anything here, so I will just remove the println.
> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java
> line 1711:
>
>> 1709: if (timeoutVal >= 0) return timeoutVal;
>> 1710: }
>> 1711: } catch (NumberFormatException ignored) {}
>
> Similarly - you could use `Log.logTrace` to print the error. It could be
> useful for diagnostic.
Good spot, would be useful. Should result in better logging with the test too.
I'll include this.
-------------
PR: https://git.openjdk.org/jdk/pull/10183
